I can understand Apple trying to curate the experience, but surely it must have occurred to someone to all apps to opt in as photo providers, and for Apple to make it an extension point.

They do it to themselves as well. If you’ve saved images or video to the files section of your iOS device you can’t pick them either.